Add data-path, extend tests, update readme#140
Open
danielmolnar992 wants to merge 2 commits into
Open
Conversation
Change-Id: Id1ab768dfaabb7868713ac238c8840406e2c98c0 GitOrigin-RevId: daf3412c40c0d2509e543470f02608b6c4761fe3
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
danielmolnar992
force-pushed
the
feat/add-data-path-parameter
branch
from
fca31db to
4110067
Compare
Author
|
This is ready for review from my side. Could someone take a look when convenient? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add custom path option to create environment with
--data-pathsimilar to--plugins-pathand--dags-path, making the local environment more customisable (defaults to the data directory inside the environment directory).All tests passed successfully.